This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(ngMessageExp): Better description #15486
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old description was copied over from ngMessage.
gkalpak
suggested changes
Dec 10, 2016
| * For `ngMessageExp` to operate, a parent `ngMessages` directive on a parent DOM element | ||
| * must be situated since it determines which messages are visible based on the state | ||
| * of the provided key/value map that `ngMessages` listens on. | ||
| * `ngMessageExp` is the same as {@link module:ngMessage `ngMessage`} but instead |
There was a problem hiding this comment.
Shouldn't this be directive:ngMessage or something (instead of module:ngMessage)?
| * must be situated since it determines which messages are visible based on the state | ||
| * of the provided key/value map that `ngMessages` listens on. | ||
| * `ngMessageExp` is the same as {@link module:ngMessage `ngMessage`} but instead | ||
| * of a DOM attribute, accepts an expression to be evaluated for the message key. |
There was a problem hiding this comment.
"DOM attribute" isn't correct. How about "static value"?
link needs to point to the ngMessage directive, and DOM attribute isn't clear enough
|
@gkalpak updated based on feedback, thanks |
gkalpak
pushed a commit
that referenced
this pull request
Dec 11, 2016
gkalpak
pushed a commit
that referenced
this pull request
Dec 11, 2016
ellimist
pushed a commit
to ellimist/angular.js
that referenced
this pull request
Mar 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
docs update
What is the current behavior? (You can also link to an open issue here)
ngMessageExp has the same description as ngMessage
What is the new behavior (if this is a feature change)?
Updated description
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information:
Old description was copied over from ngMessage.